Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix update. #317

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Fix update. #317

merged 1 commit into from
Jul 11, 2023

Conversation

abizjak
Copy link
Contributor

@abizjak abizjak commented Jul 11, 2023

Purpose

Fix update. The update function is meant to actually update the value, rather than return it.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@abizjak abizjak requested a review from orhoj July 11, 2023 11:53
@abizjak abizjak merged commit 2a9f71b into main Jul 11, 2023
121 checks passed
@abizjak abizjak deleted the fix-update branch July 11, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orhoj orhoj orhoj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abizjak @orhoj